Skip to content

Remove intercrate and mark_ambiguous from TypeRelation #109917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

Remove intercrate and mark_ambiguous from TypeRelation #109917

merged 1 commit into from
Apr 4, 2023
+22 −133

Conversation

compiler-errors
Copy link
Member

Fixes #109863

Pulls this logic into super_combine_tys, which has access to InferCtxt and takes a ObligationEmittingRelation -- both of which simplify the logic here.

r? @oli-obk @aliemjay

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Apr 4, 2023

Oh, that's smart. Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

📌 Commit a368316 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2023
@bors
Copy link
Collaborator

bors commented Apr 4, 2023

⌛ Testing commit a368316 with merge be8e5ba...

@bors
Copy link
Collaborator

bors commented Apr 4, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing be8e5ba to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 4, 2023
@bors bors merged commit be8e5ba into rust-lang:master Apr 4, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 4, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (be8e5ba): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.8% [-3.0%, -2.5%] 3
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 2
All ❌✅ (primary) -2.8% [-3.0%, -2.5%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [0.6%, 5.4%] 11
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.5% [-3.3%, -1.7%] 5
All ❌✅ (primary) 3.1% [0.6%, 5.4%] 11

@compiler-errors compiler-errors mentioned this pull request Apr 4, 2023
Closed
@aliemjay aliemjay mentioned this pull request May 6, 2023
Merged
@compiler-errors compiler-errors deleted the remove-relation-methods branch August 11, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

remove TypeRelation::{intercrate,mark_ambiguous}
5 participants
@compiler-errors @oli-obk @bors @rust-timer @rustbot